Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SebmGoogleMap): Add attribute „clickableIcons“ to map #923

Closed
wants to merge 2 commits into from
Closed

feat(SebmGoogleMap): Add attribute „clickableIcons“ to map #923

wants to merge 2 commits into from

Conversation

demianh
Copy link
Contributor

@demianh demianh commented Mar 7, 2017

This pull request adds the map option "clickableIcons" to the map as described in https://developers.google.com/maps/documentation/javascript/3.exp/reference#MapOptions

@demianh
Copy link
Contributor Author

demianh commented Mar 8, 2017

The following lines from CONTRIBUTING.md were not very clear to me:

Create your patch, including appropriate test cases.
Run the full angular-google-maps test suite with npm run build & npm run test and ensure that all tests pass.

Are there even any tests? Where do i add them?

Running the tests with npm run test throws an error for me:

WebpackOptionsValidationError: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.

Same seems to happen on the CI too...

@sebholstein
Copy link
Owner

@demianh thank you! LGTM. I will check the webpack configuration. When the build is green, I will merge your PR.

@sebholstein
Copy link
Owner

Closed with 9960522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants