Add animation field to markers #580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with your Pull Request
Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
| * Which animation to play when marker is added to a map. | ||
| * This can be "bounce" or "drop" | ||
| */ | ||
| animation: string; |
There was a problem hiding this comment.
we should use BOUNCE and DROP here
|
@orlov-vo thank you! and sorry for the late review. Added some comments. |
xdimension
pushed a commit
to xdimension/angular2-google-maps
that referenced
this pull request
Jan 13, 2017
Feature to set animation for map markers issue: Add animation field to markers sebholstein#580
xdimension
pushed a commit
to xdimension/angular2-google-maps
that referenced
this pull request
Jan 22, 2017
Feature to set animation for map markers Updated according to comments in sebholstein#852 issue: Add animation field to markers sebholstein#580
xdimension
pushed a commit
to xdimension/angular2-google-maps
that referenced
this pull request
Jan 29, 2017
Feature to set animation for map markers issue: Add animation field to markers sebholstein#580 feat: add animation field to markers Feature to set animation for map markers Updated according to comments in sebholstein#852 issue: Add animation field to markers sebholstein#580
xdimension
pushed a commit
to xdimension/angular2-google-maps
that referenced
this pull request
Jan 29, 2017
Feature to set animation for map markers issue: Add animation field to markers sebholstein#580
xdimension
pushed a commit
to xdimension/angular2-google-maps
that referenced
this pull request
Jan 29, 2017
Feature to set animation for map markers issue: Add animation field to markers sebholstein#580
xdimension
pushed a commit
to xdimension/angular2-google-maps
that referenced
this pull request
Feb 11, 2017
Feature to set animation for map markers issue: Add animation field to markers sebholstein#580
xdimension
pushed a commit
to xdimension/angular2-google-maps
that referenced
this pull request
Feb 13, 2017
Feature to set animation for map markers issue: Add animation field to markers sebholstein#580
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.