Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): rename ANGULAR2_GOOGLE_MAPS_* constants #406

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/_partials/homepage/quickstart-example.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ import {Component} from '@angular/core';
import {bootstrap} from '@angular/platform-browser-dynamic';

import {
ANGULAR2_GOOGLE_MAPS_DIRECTIVES,
ANGULAR2_GOOGLE_MAPS_PROVIDERS
GOOGLE_MAPS_DIRECTIVES,
GOOGLE_MAPS_PROVIDERS
} from 'angular2-google-maps/core';

@Component({
selector: 'app-component',
directives: [ANGULAR2_GOOGLE_MAPS_DIRECTIVES]
directives: [GOOGLE_MAPS_DIRECTIVES]
template: `
<sebm-google-map [latitude]="lat" [longitude]="lng">
</sebm-google-map>
Expand All @@ -19,4 +19,4 @@ class AppComponent {
lng: number = 33.2;
}

bootstrap(AppComponent, [ANGULAR2_GOOGLE_MAPS_PROVIDERS]);
bootstrap(AppComponent, [GOOGLE_MAPS_PROVIDERS]);
10 changes: 5 additions & 5 deletions docs/getting-started.jade
Original file line number Diff line number Diff line change
Expand Up @@ -344,11 +344,11 @@ a.button.button-icon.blue-light(href='http://plnkr.co/edit/YX7W20?p=preview') &r
:marked
```typescript
import {Component} from '@angular/core';
import {ANGULAR2_GOOGLE_MAPS_DIRECTIVES} from 'angular2-google-maps/core';
import {GOOGLE_MAPS_DIRECTIVES} from 'angular2-google-maps/core';

@Component({
selector: 'my-app',
directives: [ANGULAR2_GOOGLE_MAPS_DIRECTIVES], // this loads all angular2-google-maps directives in this component
directives: [GOOGLE_MAPS_DIRECTIVES], // this loads all angular2-google-maps directives in this component
// the following line sets the height of the map - Important: if you don't set a height, you won't see a map!!
styles: [`
.sebm-google-map-container {
Expand Down Expand Up @@ -385,11 +385,11 @@ a.button.button-icon.blue-light(href='http://plnkr.co/edit/YX7W20?p=preview') &r
```typescript
import {bootstrap} from '@angular/platform-browser-dynamic';
import {AppComponent} from './app.component';
import {ANGULAR2_GOOGLE_MAPS_PROVIDERS} from 'angular2-google-maps/core';
import {GOOGLE_MAPS_PROVIDERS} from 'angular2-google-maps/core';

// this line boots our application on the page in the <my-app> element:
// Note: It is required to add the ANGULAR2_GOOGLE_MAPS_PROVIDERS here!
bootstrap(AppComponent, [ANGULAR2_GOOGLE_MAPS_PROVIDERS]);
// Note: It is required to add the GOOGLE_MAPS_PROVIDERS here!
bootstrap(AppComponent, [GOOGLE_MAPS_PROVIDERS]);
```
### Final project structure
Our final project structure should look like this:
Expand Down
2 changes: 1 addition & 1 deletion src/core/directives-const.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ import {SebmGoogleMap} from './directives/google-map';
import {SebmGoogleMapInfoWindow} from './directives/google-map-info-window';
import {SebmGoogleMapMarker} from './directives/google-map-marker';

export const ANGULAR2_GOOGLE_MAPS_DIRECTIVES: any[] =
export const GOOGLE_MAPS_DIRECTIVES: any[] =
[SebmGoogleMap, SebmGoogleMapMarker, SebmGoogleMapInfoWindow];
2 changes: 1 addition & 1 deletion src/core/directives.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export {ANGULAR2_GOOGLE_MAPS_DIRECTIVES} from './directives-const';
export {GOOGLE_MAPS_DIRECTIVES} from './directives-const';
export {SebmGoogleMap} from './directives/google-map';
export {SebmGoogleMapInfoWindow} from './directives/google-map-info-window';
export {SebmGoogleMapMarker} from './directives/google-map-marker';
2 changes: 1 addition & 1 deletion src/core/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ export * from './directives';
export * from './services';
export * from './events';

export const ANGULAR2_GOOGLE_MAPS_PROVIDERS: any[] = [
export const GOOGLE_MAPS_PROVIDERS: any[] = [
new Provider(MapsAPILoader, {useClass: LazyMapsAPILoader}),
];