-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat): support angular2.0.0-rc.1 #339
Conversation
There were the following issues with your Pull Request
Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
There were the following issues with your Pull Request
Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
'rxjs/*': './node_modules/rxjs/*', | ||
}, | ||
packages: { | ||
'@angular/core': { main: 'index.js', defaultExtension: 'js' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carl09 can we add common here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and compiler
@carl09 Thank you for PR. Good job! I added some comments. Can you address these comments today and squash all commits to one? Thanks man! |
@carl09 I have made the changes and merged it. Thanks for your time! |
@SebastianM Thanks for the review i am new to gulp, karma and angular2. it was fun to have a go though. I just had a look at what you fixed up, looks really good, just woke up.. Thanks for creating this project it will be really helpful. |
(feat): support angular2.0.0-rc.1
updated library to use angular2.0.0-rc.1 for issue #331