Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: consistent/useful naming #395

Closed
2 tasks done
sebholstein opened this issue Jun 7, 2016 · 3 comments
Closed
2 tasks done

feat: consistent/useful naming #395

sebholstein opened this issue Jun 7, 2016 · 3 comments
Labels
P1: urgent type: feature-request
Milestone
0.11.0

Comments

@sebholstein
Copy link
Owner

sebholstein commented Jun 7, 2016 •
edited
Loading

  • change ANGULAR2_GOOGLE_MAPS_* to GOOGLE_MAPS_*
  • change GoogleMapsAPIWrapper.getMap to -> GoogleMapsAPIWrapper.getNativeMap
@sebholstein sebholstein added this to the 0.11.0 milestone Jun 7, 2016
@rijine
Copy link

rijine commented Jun 8, 2016 •
edited
Loading

how about changing "<sebm-google-map> to <google-map>" ..:)

@sebholstein sebholstein mentioned this issue Jun 8, 2016
Closed
sebholstein added a commit that referenced this issue Jun 8, 2016
@sebholstein
feat(*): rename ANGULAR2_GOOGLE_MAPS_* constants
3ead15e 
This removes the ANGULAR2_ prefix.

BREAKING CHANGES

`ANGULAR2_GOOGLE_MAPS_PROVIDERS` is now called `GOOGLE_MAPS_PROVIDERS`.
`ANGULAR2_GOOGLE_MAPS_DIRECTIVES`is now called `GOOGLE_MAPS_DIRECTIVES`.

Please update existing import of these two constants in your code.

Related to #395
@sebholstein sebholstein mentioned this issue Jun 8, 2016
Closed
sebholstein added a commit that referenced this issue Jun 8, 2016
@sebholstein
feat(*): rename ANGULAR2_GOOGLE_MAPS_* constants
8efa96d 
This removes the ANGULAR2_ prefix.

BREAKING CHANGES

`ANGULAR2_GOOGLE_MAPS_PROVIDERS` is now called `GOOGLE_MAPS_PROVIDERS`.
`ANGULAR2_GOOGLE_MAPS_DIRECTIVES`is now called `GOOGLE_MAPS_DIRECTIVES`.

Please update existing import of these two constants in your code.

Related to #395
Closes #406
@sebholstein
Copy link
Owner Author

@rijine hmm no, I don't want to use the google- prefix. As long it is not possible to overwrite a component selector, I'll stick with my prefix.

@sebholstein
Copy link
Owner Author

Landed as f2084dd and 8efa96d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1: urgent type: feature-request
Projects
None yet
Milestone
0.11.0
Development

No branches or pull requests
2 participants
@sebholstein @rijine