fix(AgmMap): memory leak when map gets destroyed

sebholstein · May 23, 2018 · 6006617 · 6006617
1 parent 078c2a5
commit 6006617
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/packages/core/directives/map.ts b/packages/core/directives/map.ts
@@ -374,6 +374,9 @@ export class AgmMap implements OnChanges, OnInit, OnDestroy {
   ngOnDestroy() {
     // unsubscribe all registered observable subscriptions
     this._observableSubscriptions.forEach((s) => s.unsubscribe());
+
+    // remove all listeners from the map instance
+    this._mapsWrapper.clearInstanceListeners();
   }
 
   /* @internal */

diff --git a/packages/core/services/google-maps-api-wrapper.ts b/packages/core/services/google-maps-api-wrapper.ts
@@ -107,6 +107,12 @@ export class GoogleMapsAPIWrapper {
     });
   }
 
+  clearInstanceListeners() {
+    this._map.then((map: mapTypes.GoogleMap) => {
+      google.maps.event.clearInstanceListeners(map);
+    });
+  }
+
   setCenter(latLng: mapTypes.LatLngLiteral): Promise<void> {
     return this._map.then((map: mapTypes.GoogleMap) => map.setCenter(latLng));
   }