Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualizer backport V3 to v2 #42

Open
wants to merge 5 commits into
base: v2
Choose a base branch
from

Conversation

judgej
Copy link
Contributor

@judgej judgej commented May 25, 2020

Backport of the visualizer command from v3 to v2, for use with Laravel v5.

Skullbock and others added 3 commits May 25, 2020 22:00
The state and transition names can contain dashes, and those result in a syntax error in the generated dot file.
@judgej
Copy link
Contributor Author

judgej commented May 25, 2020

Not for merging yet - I'm going to run some local tests to see if there are other commits I have missed first. This gets some automated tests in, in the meantime.

@judgej
Copy link
Contributor Author

judgej commented May 25, 2020

This is working for me nicely in Laravel 5.8 and PHP 7.3. Although I'll be upgrading the Laravel version soon, it's all about timing and compatibility with other packages, and not all projects are in a position to do that immediately.

This PR tackles just the backport, with no feature changes, preserving all original committer credits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants