Fix StringValue.Create encode overload. (#750)

Co-authored-by: Sébastien Ros <[email protected]>
sebastienros · Feb 1, 2025 · 023a49b · 023a49b
1 parent bbc16a2
commit 023a49b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/Fluid.Tests/StringValueTests.cs b/Fluid.Tests/StringValueTests.cs
@@ -27,5 +27,17 @@ public void StringValueCreateNullShouldReturnEmpty()
             // Assert
             Assert.Equal(StringValue.Empty, stringValue);
         }
+
+        [Theory]
+        [InlineData(true)]
+        [InlineData(false)]
+        public void StringValue_Create_InitializesProperties(bool encode)
+        {
+            var stringValue = StringValue.Create("a", encode);
+
+            // Assert
+            Assert.Equal("a", stringValue.ToStringValue());
+            Assert.Equal(encode, stringValue.Encode);
+        }
     }
 }
diff --git a/Fluid/Values/StringValue.cs b/Fluid/Values/StringValue.cs
@@ -70,7 +70,7 @@ public static StringValue Create(string s)
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static StringValue Create(string s, bool encode)
         {
-            return Create(s, encode);
+            return new StringValue(s, encode);
         }
 
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
@@ -93,7 +93,7 @@ public override bool Equals(FluidValue other)
                 return _value == other.ToStringValue();
             }
 
-            // Delegating other types 
+            // Delegating other types
             if (other == BlankValue.Instance || other == NilValue.Instance || other == EmptyValue.Instance)
             {
                 return other.Equals(this);