Improve parameter name for assertGreaterThan(), assertGreaterThanOrEqual(), assertLessThan(), and assertLessThanOrEqual()

[semkoolennl]

Resolves #5849

Improved the $expected parameter name for the following constraints:

• assertGreaterThan()
• assertGreaterThanOrEqual()
• assertLessThan()
• assertLessThanOrEqual()

I decided to use minimum and maximum as parameter names as these make the comparisons clear and intuitive.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.73%. Comparing base (0562f48) to head (efcbdca).

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #6010   +/-   ##
=========================================
  Coverage     94.73%   94.73%           
  Complexity     6439     6439           
=========================================
  Files           697      697           
  Lines         20252    20252           
=========================================
  Hits          19185    19185           
  Misses         1067     1067           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sebastianbergmann]

Cherry-picked into 11.4 and merged to 11.5 and main from there. Thanks!

[NanoSector]

Just wanted to note that this broke some of our tests with a dependency update, as we used named parameters with these functions.

Not sure if that can be seen as a backwards compatibility break in a patch version.

[sebastianbergmann]

Not sure if that can be seen as a backwards compatibility break in a patch version.

With PHPUnit, this is never a backwards compatibility break. Every source file of PHPUnit has this at the top:

/**
 * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
 */

See https://github.com/sebastianbergmann/phpunit/blob/11.4.3/src/Framework/Assert.php#L70-L72, for example and the Backward Compatibility page.

[NanoSector]

Ah apologies, I was looking for that mention/page in the documentation and could not find it, I hadn't looked in the code or on the main site.