Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #5893

Closed
wants to merge 1 commit into from
Closed

Conversation

lolli42
Copy link
Contributor

@lolli42 lolli42 commented Jul 9, 2024

Raise sebatian/global-state from ^7.0 to ^7.0.2
to especially have some bug fixes required for
PHP 8.4 compat.

Raise sebatian/global-state from ^7.0 to ^7.0.2
to especially have some bug fixes required for
PHP 8.4 compat.

> composer req sebastian/global-state:^7.0.2
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.37%. Comparing base (ef78375) to head (9b23471).

Additional details and impacted files
@@            Coverage Diff            @@
##               11.2    #5893   +/-   ##
=========================================
  Coverage     92.37%   92.37%           
  Complexity     6563     6563           
=========================================
  Files           699      699           
  Lines         19791    19791           
=========================================
  Hits          18281    18281           
  Misses         1510     1510           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann
Copy link
Owner

I assume the PHP 8.4 compatiblity issue you refer to is sebastianbergmann/global-state@c3a307e which was fixed in sebastian/global-state v7.0.1.

Are you proposing this change to composer.json because you use Composer's --prefer-lowest option? Because that would be the only situation when I can see this to have an effect.

@lolli42
Copy link
Contributor Author

lolli42 commented Jul 9, 2024

Yes. I'm proposing this raise due to our --prefer-lowest tests. I'd however understand, if you're hesitant to a raise. We may end up not running our "min" with PHP 8.4 anyways. Just close if you don't like it.

@sebastianbergmann
Copy link
Owner

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it. Instead, I bumped all dependencies on the 8.5, 9.6, 10.5, 11.2, and main branches:

sebastianbergmann referenced this pull request Jul 11, 2024
…er-lowest CLI option also get recent versions)
@lolli42 lolli42 deleted the lolli-2 branch July 11, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants