Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail run with invalid data providers #5291

Closed
wants to merge 1 commit into from

Conversation

marmichalski
Copy link
Contributor

Before continuing with this, I assume the current behaviour is indeed wrong, @sebastianbergmann? This test currently fails with:

-PHPUnit Finished (Shell Exit Code: 1)
+PHPUnit Finished (Shell Exit Code: 0)

What it means is, if you have a test with invalid/missing data provider and another one that is passing, the whole run is considered success.

@sebastianbergmann
Copy link
Owner

Thank you for bringing this to my attention, and for providing a test case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants