assertObjectHasProperty() and assertObjectNotHasProperty()

[jasverix]

Added PR for PhpUnit 10.0. Still not sure if you accept the feature request at all, but then the PR is at least here.

If accepted, I can try to make a "small-as-possible" change for PhpUnit 9 so we can get rid of the deprecation warnings. Just add the new methods and let them call the old methods or something.

If you don't want the feature, then it is OK, but then I will probably add the code in our codebase instead, because we cannot live without them in our API tests 😅

Fix #5220

[sebastianbergmann]

Still not sure if you accept the feature request at all, but then the PR is at least here.

I am open to the idea and will review this PR as soon as I find the time.

I can try to make a "small-as-possible" change for PhpUnit 9 so we can get rid of the deprecation warnings.

PHPUnit 9 is closed for additions.

[sebastianbergmann]

Did you add ClassHasProperty (https://github.com/sebastianbergmann/phpunit/pull/5229/files#diff-69d378dcbcd5862a44ba12f6649211842df4255a14a2e500b1de62f0275bd07d) by mistake?

[jasverix]

Yeah, I actually just fetched the old classes from 9 and renamed them. Have gone through the code now and removed ClassHasProperty, and added the two new functions to Functions.php.

[sebastianbergmann]

Can you please fix the coding guidelines and type checker issues and squash your changes into a single commit when you're done? Thanks!

[codecov]

Codecov Report

Merging #5229 (652a86f) into main (94ec320) will increase coverage by 0.02%.
The diff coverage is 94.11%.

❗ Current head 652a86f differs from pull request most recent head b43b852. Consider uploading reports for the commit b43b852 to get more accurate results

@@             Coverage Diff              @@
##               main    #5229      +/-   ##
============================================
+ Coverage     81.30%   81.33%   +0.02%     
- Complexity     5853     5863      +10     
============================================
  Files           629      630       +1     
  Lines         18544    18578      +34     
============================================
+ Hits          15078    15110      +32     
- Misses         3466     3468       +2     

Impacted Files	Coverage Δ
.../Framework/Constraint/Object/ObjectHasProperty.php	90.00% <90.00%> (ø)
src/Framework/Assert.php	92.93% <100.00%> (+0.13%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more