-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CodeCoverage: refactor to pure Singleton #5179
Merged
sebastianbergmann
merged 6 commits into
sebastianbergmann:10.0
from
Slamdunk:codecoverage_pure_singleton
Feb 7, 2023
Merged
CodeCoverage: refactor to pure Singleton #5179
sebastianbergmann
merged 6 commits into
sebastianbergmann:10.0
from
Slamdunk:codecoverage_pure_singleton
Feb 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianbergmann
added
type/refactoring
A refactoring that should be applied to make the code easier to understand and maintain
feature/test-runner
CLI test runner
labels
Feb 7, 2023
Codecov Report
@@ Coverage Diff @@
## 10.0 #5179 +/- ##
============================================
- Coverage 81.28% 81.27% -0.02%
- Complexity 5841 5843 +2
============================================
Files 629 629
Lines 18511 18512 +1
============================================
- Hits 15047 15045 -2
- Misses 3464 3467 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…odeCoverage::codeCoverage()
sebastianbergmann
force-pushed
the
codecoverage_pure_singleton
branch
from
February 7, 2023 14:22
6eceb69
to
69b138a
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/test-runner
CLI test runner
type/refactoring
A refactoring that should be applied to make the code easier to understand and maintain
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR sets a clear line between the Singleton instance and its behaviour for:
\PHPUnit\TextUI\Configuration\CodeCoverageFilterRegistry
\PHPUnit\Runner\CodeCoverage
Allowing to have local instances that do not interfere with active PHPUnit run.
For PHPUnit the benefit is that these classes become now unit-testable, if needed.
For external project like ParaTest (I'm aware that I'm dealing with
@internal
classes) this means these classes can be used without mangling PHPUnit internal state.