Added assertArrayIsList() #4818
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebastianbergmann Would you accept this when I add more tests etc? |
sebastianbergmann
added
feature/assertion
Yes. |
Codecov Report
@@ Coverage Diff @@
## master #4818 +/- ##
============================================
+ Coverage 83.57% 83.60% +0.02%
- Complexity 5797 5806 +9
============================================
Files 548 549 +1
Lines 15596 15617 +21
============================================
+ Hits 13035 13056 +21
Misses 2561 2561
Continue to review full report at Codecov.
|
kukulich
force-pushed
the
assert-array-is-list
branch
2 times, most recently
from
3cb32f6 to
0f147f5
Compare
|
It looks the fail of type checker is not related to this patch. |
I'll look into this. |
kukulich
force-pushed
the
assert-array-is-list
branch
from
0f147f5 to
1e6db30
Compare
derrabus
reviewed
Dec 13, 2021
| if ($other === []) { | ||
| return true; | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| if (function_exists('array_is_list')) { | |
| return array_is_list($other); | |
| } | |
On PHP 8.1, we have a native function for that. I suggest we leverage it if it's available.
sebastianbergmann
added a commit
that referenced
this pull request
Dec 18, 2021
Suggested by Alexander M. Turek <[email protected]> in #4818 (review)
|
Merged manually. Thanks! |
jrfnl
added a commit
to Yoast/PHPUnit-Polyfills
that referenced
this pull request
Mar 30, 2023
…method
PHPUnit 10.0.0 introduces the new `Assert::assertIsList()` method.
This commit:
* Adds two traits with the same name.
One to polyfill the methods when not available in PHPUnit.
The other - an empty trait - to allow for `use`-ing the trait in PHPUnit versions in which the methods are already natively available.
* Logic to the custom autoloader which will load the correct trait depending on the PHPUnit version used.
* Functional tests for the functionality polyfilled.
Note: the methods use `static::` to call the PHPUnit native functionality. This allows for existing method overloads in a child class of the PHPUnit native `TestCase` to be respected.
Includes:
* Adding the new polyfill to the existing `TestCases` classes and adding a test for the polyfill availability to the `TestCaseTestTrait`.
Refs:
* sebastianbergmann/phpunit#4818
* sebastianbergmann/phpunit@71f5074
* sebastianbergmann/phpunit@e04a947
* sebastianbergmann/phpunit@2bc1aea
Co-authored-by: Jaroslav Hanslík <[email protected]>
Co-authored-by: Sebastian Bergmann <[email protected]>
jrfnl
added a commit
to Yoast/PHPUnit-Polyfills
that referenced
this pull request
Mar 30, 2023
…method
PHPUnit 10.0.0 introduces the new `Assert::assertIsList()` method.
This commit:
* Adds two traits with the same name.
One to polyfill the methods when not available in PHPUnit.
The other - an empty trait - to allow for `use`-ing the trait in PHPUnit versions in which the methods are already natively available.
* Logic to the custom autoloader which will load the correct trait depending on the PHPUnit version used.
* Functional tests for the functionality polyfilled.
Note: the methods use `static::` to call the PHPUnit native functionality. This allows for existing method overloads in a child class of the PHPUnit native `TestCase` to be respected.
Includes:
* Adding the new polyfill to the existing `TestCases` classes and adding a test for the polyfill availability to the `TestCaseTestTrait`.
Refs:
* sebastianbergmann/phpunit#4818
* sebastianbergmann/phpunit@71f5074
* sebastianbergmann/phpunit@e04a947
* sebastianbergmann/phpunit@2bc1aea
Co-authored-by: Jaroslav Hanslík <[email protected]>
Co-authored-by: Sebastian Bergmann <[email protected]>
jrfnl
added a commit
to Yoast/PHPUnit-Polyfills
that referenced
this pull request
Mar 30, 2023
…method
PHPUnit 10.0.0 introduces the new `Assert::assertIsList()` method.
This commit:
* Adds two traits with the same name.
One to polyfill the methods when not available in PHPUnit.
The other - an empty trait - to allow for `use`-ing the trait in PHPUnit versions in which the methods are already natively available.
* Logic to the custom autoloader which will load the correct trait depending on the PHPUnit version used.
* Functional tests for the functionality polyfilled.
Note: the methods use `static::` to call the PHPUnit native functionality. This allows for existing method overloads in a child class of the PHPUnit native `TestCase` to be respected.
Includes:
* Adding the new polyfill to the existing `TestCases` classes and adding a test for the polyfill availability to the `TestCaseTestTrait`.
Refs:
* sebastianbergmann/phpunit#4818
* sebastianbergmann/phpunit@71f5074
* sebastianbergmann/phpunit@e04a947
* sebastianbergmann/phpunit@2bc1aea
Co-authored-by: Jaroslav Hanslík <[email protected]>
Co-authored-by: Sebastian Bergmann <[email protected]>
jrfnl
added a commit
to Yoast/PHPUnit-Polyfills
that referenced
this pull request
Apr 1, 2023
…method
PHPUnit 10.0.0 introduces the new `Assert::assertIsList()` method.
This commit:
* Adds two traits with the same name.
One to polyfill the methods when not available in PHPUnit.
The other - an empty trait - to allow for `use`-ing the trait in PHPUnit versions in which the methods are already natively available.
* Logic to the custom autoloader which will load the correct trait depending on the PHPUnit version used.
* Functional tests for the functionality polyfilled.
Note: the methods use `static::` to call the PHPUnit native functionality. This allows for existing method overloads in a child class of the PHPUnit native `TestCase` to be respected.
Includes:
* Adding the new polyfill to the existing `TestCases` classes and adding a test for the polyfill availability to the `TestCaseTestTrait`.
Refs:
* sebastianbergmann/phpunit#4818
* sebastianbergmann/phpunit@71f5074
* sebastianbergmann/phpunit@e04a947
* sebastianbergmann/phpunit@2bc1aea
Co-authored-by: Jaroslav Hanslík <[email protected]>
Co-authored-by: Sebastian Bergmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.