Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove --loader arg and config options #4531

Conversation

realFlowControl
Copy link
Contributor

This PR removes the --loader command line argument as well as the testSuiteLoaderClass and testSuiteLoaderFile configuration options as stated in #4524

@realFlowControl realFlowControl changed the title #4524 remove --loader arg and config options remove --loader arg and config options Nov 29, 2020
@realFlowControl realFlowControl changed the title remove --loader arg and config options remove --loader arg and config options Nov 29, 2020
@realFlowControl realFlowControl mentioned this pull request Nov 29, 2020
3 tasks
@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #4531 (92fbf4f) into master (d86b1ee) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4531      +/-   ##
============================================
+ Coverage     84.31%   84.35%   +0.03%     
+ Complexity     4625     4613      -12     
============================================
  Files           275      275              
  Lines         11964    11932      -32     
============================================
- Hits          10088    10065      -23     
+ Misses         1876     1867       -9     
Impacted Files Coverage Δ Complexity Δ
src/TextUI/CliArguments/Builder.php 80.18% <ø> (+0.27%) 121.00 <0.00> (-1.00) ⬆️
src/TextUI/CliArguments/Mapper.php 79.51% <ø> (+0.35%) 82.00 <0.00> (-1.00) ⬆️
src/TextUI/XmlConfiguration/Loader.php 97.59% <ø> (-0.02%) 134.00 <0.00> (-1.00)
src/Runner/BaseTestRunner.php 86.20% <100.00%> (+5.56%) 9.00 <0.00> (-1.00) ⬆️
src/TextUI/CliArguments/Configuration.php 68.58% <100.00%> (+0.28%) 269.00 <1.00> (-3.00) ⬆️
src/TextUI/Command.php 74.59% <100.00%> (-0.17%) 118.00 <0.00> (-3.00)
src/TextUI/TestRunner.php 66.23% <100.00%> (-0.44%) 226.00 <2.00> (-2.00)
src/TextUI/XmlConfiguration/PHPUnit/PHPUnit.php 96.51% <100.00%> (-0.05%) 62.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d86b1ee...92fbf4f. Read the comment docs.

@realFlowControl realFlowControl force-pushed the remove-test-suite-loader-argument branch from 738fb5e to 92fbf4f Compare November 29, 2020 19:34
@sebastianbergmann
Copy link
Owner

I will merge this once master is PHPUnit 10 (after December 4, 2020).

@sebastianbergmann sebastianbergmann self-assigned this Nov 30, 2020
@sebastianbergmann sebastianbergmann added feature/test-runner CLI test runner type/backward-compatibility Something will be/is intentionally broken type/refactoring A refactoring that should be applied to make the code easier to understand and maintain labels Nov 30, 2020
@sebastianbergmann sebastianbergmann added this to the PHPUnit 10.0 milestone Nov 30, 2020
@sebastianbergmann sebastianbergmann marked this pull request as ready for review December 4, 2020 07:26
@sebastianbergmann
Copy link
Owner

Merged manually, thanks!

@realFlowControl realFlowControl deleted the remove-test-suite-loader-argument branch December 17, 2020 19:35
sebastianbergmann added a commit that referenced this pull request Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/test-runner CLI test runner type/backward-compatibility Something will be/is intentionally broken type/refactoring A refactoring that should be applied to make the code easier to understand and maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants