-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logging of TestSuite setup failures #3428
Merged
sebastianbergmann
merged 10 commits into
sebastianbergmann:7.5
from
epdenouden:issue-3364-show-testsuite-setup-failures
Nov 30, 2018
Merged
Fix logging of TestSuite setup failures #3428
sebastianbergmann
merged 10 commits into
sebastianbergmann:7.5
from
epdenouden:issue-3364-show-testsuite-setup-failures
Nov 30, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new 'instanceof TestCase' check does indeed hide errors in setUpBeforeClass, but there is also a problem with counting the number of tests returned when counting the result.
Codecov Report
@@ Coverage Diff @@
## 7.5 #3428 +/- ##
============================================
+ Coverage 83.24% 83.24% +<.01%
+ Complexity 3629 3628 -1
============================================
Files 143 143
Lines 9660 9653 -7
============================================
- Hits 8041 8036 -5
+ Misses 1619 1617 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3364
If
setUpBeforeClass
failed, theTestSuite
would send its own details to the listeners for each test, instead of details about individual failing tests. Fixing this makes the errors visible again including code location hints and exception messages.It also corrects the reported number of tests that are run in case of setup failure when running with
--stop-on-error
.Output in IntelliJ 2018.3 using TeamCity:
This also works for other log formats. Default printer:
TestDox: