Fixed incompatibility with HHVM in PHP7 mode. #2390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also facebook/hhvm#7537.
HHVM has a "PHP7 mode" that can be enabled with an INI setting. Currently PHPUnit skipped tests (and probably other features) do not work in this mode because of an HHVM incompatibility involving
instanceofused with a variable containing'Throwable'as the type.I realize that you could simply wait until HHVM addresses this issue, but hopefully you will consider accepting this PR in any case, as it will allow PHPUnit to function correctly on older versions of HHVM that are unlikely to be patched.