Add interface to specify custom.css file for HTML report #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to sebastianbergmann#556. It would help to make the custom CSS feature more accessible by making the file a configuration option, e.g. in phpunit: <coverage> <report> <html customCssFile="path/to/custom.css" /> </report> </coverage> The `$customCssFile` argument is added to the Html\Facade interface as a prerequisite to any changes to phpunit configuration options. If not null, it copies this file to the custom.css destination instead of the empty custom.css stub file.
Codecov Report
@@ Coverage Diff @@
## 9.2 #901 +/- ##
============================================
+ Coverage 83.37% 85.74% +2.36%
- Complexity 1127 1550 +423
============================================
Files 59 61 +2
Lines 3237 4741 +1504
============================================
+ Hits 2699 4065 +1366
- Misses 538 676 +138
Continue to review full report at Codecov.
|
|
Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it. I think that this should be handled outside of php-code-coverage (and PHPUnit). Your build automation should copy your |
|
Meditate on this, I shall. |
|
Superseded by cd4b129. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #556.
It would help to make the custom CSS feature more accessible by making
the file a configuration option, e.g. in phpunit:
The
$customCssFileargument is added to the Html\Facade interface asa prerequisite to any changes to phpunit configuration options. If not
null, it copies this file to the custom.css destination instead of the
empty custom.css stub file.
A couple logistical notes:
Thanks for your time!