Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XdebugFileDriver #872

Closed
wants to merge 1 commit into from
Closed

Conversation

meeuw
Copy link

@meeuw meeuw commented Oct 18, 2021

Like suggested in sebastianbergmann/phpcov#111

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it because I do not want code coverage driver specific code in this tool.

I think it would make sense to add functionality in php-code-coverage to serialize that component's object graph to JSON (and vice versa).

First, thanks for you quick response. That's exceptional!

I've tried to implement this in class CodeCoverage without using the drivers module but CodeCoverage depends too much on a loaded driver (it's even an argument for the constructor).

Is this PR sufficient or would you like to have an implementation (CodeCoverage::fromXdebugJSON() and $codeCoverage->toXdebugJSON()) as part of this PR (which will use the XdebugFileDriver)?

@sebastianbergmann
Copy link
Owner

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.

What I wanted to suggest was to serialize a SebastianBergmann\CodeCoverage\CodeCoverage object to JSON and vice versa, I am sorry if I did not make that clear enough.

I agree that this is a problem that should be solved, but I need to think more about how to best solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants