Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like suggested in sebastianbergmann/phpcov#111
First, thanks for you quick response. That's exceptional!
I've tried to implement this in
class CodeCoverage
without using the drivers module butCodeCoverage
depends too much on a loaded driver (it's even an argument for the constructor).Is this PR sufficient or would you like to have an implementation (
CodeCoverage::fromXdebugJSON()
and$codeCoverage->toXdebugJSON()
) as part of this PR (which will use theXdebugFileDriver
)?