fixed namespace handling from removing more than the tail.

[MeRoBo]

namespace handling is stripping more than the tail, causing

unserialize(): Error at offset 209854 of 284023 bytes

[
"name" => "Daemon",
"namespacedName" => "Foo\Infrastructure\Daemon\Watchdog\Daemon",
"namespace" => "Foo\Infrastructure\Watchdog";
...]

[codecov]

Codecov Report

Merging #797 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #797      +/-   ##
============================================
- Coverage     83.03%   83.00%   -0.03%     
  Complexity     1114     1114              
============================================
  Files            60       60              
  Lines          3418     3413       -5     
============================================
- Hits           2838     2833       -5     
  Misses          580      580              

Impacted Files	Coverage Δ	Complexity Δ
src/StaticAnalysis/CodeUnitFindingVisitor.php	78.07% <100.00%> (-0.93%)	40.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1894b1a...68e82f5. Read the comment docs.

[sebastianbergmann]

Please avoid changing existing test fixture.

[sebastianbergmann]

namespace handling is stripping more than the tail

To make this explicit: when the name of the class is part of the namespace name then it is wrongly removed from the namespace name. Good catch! This is a bug that should be fixed.

unserialize(): Error at offset 209854 of 284023 bytes

However, I do not understand how a wrong namespace name results in an unserialize() error.

[MeRoBo]

Hi Sebastianbergmann, The unserialize doesn’t like the double \ in the namespace value, that is what brought it to our attention. Unfortunately git hub removed the double \ in the request. Thanks for the merge.

…

On Wed, 19 Aug 2020 at 15:09, Sebastian Bergmann ***@***.***> wrote: Merged #797 <#797> into master. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#797 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMKAIDZI5ZWQEJE7LNR3GFLSBNM7BANCNFSM4QEOVQFA> .