Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache Warmer does not warm all caches #791

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Cache Warmer does not warm all caches #791

merged 1 commit into from
Aug 10, 2020

Conversation

Slamdunk
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #791 into master will increase coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #791      +/-   ##
============================================
+ Coverage     82.67%   83.02%   +0.34%     
  Complexity     1113     1113              
============================================
  Files            60       60              
  Lines          3406     3410       +4     
============================================
+ Hits           2816     2831      +15     
+ Misses          590      579      -11     
Impacted Files Coverage Δ Complexity Δ
src/StaticAnalysis/CacheWarmer.php 100.00% <100.00%> (+100.00%) 2.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9871cf4...4e7ad5a. Read the comment docs.

@@ -29,8 +29,16 @@ public function warmCache(string $cacheDirectory, bool $useAnnotationsForIgnorin
);

foreach ($filter->files() as $file) {
/* @noinspection UnusedFunctionResultInspection */
$coveredFileAnalyser->classesIn($file);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are needed too because cache are per-method:

protected function cacheFile(string $filename, string $method): string
{
return $this->directory . DIRECTORY_SEPARATOR . hash('sha256', $filename . $method);
}

@sebastianbergmann sebastianbergmann self-assigned this Aug 10, 2020
@sebastianbergmann sebastianbergmann merged commit 8673460 into sebastianbergmann:master Aug 10, 2020
@Slamdunk Slamdunk deleted the fix_partial_cache_warmup branch August 10, 2020 07:19
@sebastianbergmann sebastianbergmann changed the title CacheWarmer: call all available methods for caching Cache Warmer does not warm all caches Aug 10, 2020
@sebastianbergmann
Copy link
Owner

Thank you, Filippo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants