Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework how code coverage settings are propagated to the driver #752

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
0eb29be
Remove some ancient workarounds for very old Xdebug versions
dvdoug Apr 29, 2020
48b9ad2
Use Xdebug's built-in filter
dvdoug May 13, 2020
c0fb088
Use PCOV's built-in filter
dvdoug May 13, 2020
add204d
Update Psalm baseline
sebastianbergmann May 13, 2020
0069dfb
We do not need to keep a reference to the Filter object
sebastianbergmann May 13, 2020
a511164
Fix CS/WS issues
sebastianbergmann May 13, 2020
0be1afd
Update Psalm baseline
sebastianbergmann May 13, 2020
3203df5
Encapsulate raw coverage data from drivers
dvdoug May 13, 2020
9cc3838
Fix issues identified by Psalm
sebastianbergmann May 14, 2020
07b8108
Remove superfluous code
sebastianbergmann May 14, 2020
a01b163
Use strict comparison
sebastianbergmann May 14, 2020
06bfa0c
Rename lineData to lineCoverage
sebastianbergmann May 14, 2020
3699d42
Change PHP report to use serialize, rather than var_export for better…
dvdoug May 15, 2020
659ef5c
Encapsulate processed coverage data
dvdoug May 14, 2020
4dcffe3
Use named constructors as requested
dvdoug May 14, 2020
68764da
Make test class final
sebastianbergmann May 16, 2020
20d0021
Fix typo
sebastianbergmann May 16, 2020
e2d8b85
Suppress PhpStorm's unused function result inspection
sebastianbergmann May 16, 2020
0e37923
Remove superfluous braces
sebastianbergmann May 16, 2020
76e16f3
Fix CS/WS issue introduced in e2d8b8527cff94e72faee8d344c69fe7bd4bce44
sebastianbergmann May 16, 2020
a707e74
Improve consistency in handling of namespaces
dvdoug May 12, 2020
227fa31
Add additional tests for text report
dvdoug May 18, 2020
f0d58f7
Correct missing highlighting of dead code
dvdoug May 18, 2020
ed411cb
Rework how code coverage settings are propagated to the driver
dvdoug May 18, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions .psalm/baseline.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,14 @@
</PossiblyUndefinedMethod>
</file>
<file src="src/Driver/Xdebug.php">
<UndefinedConstant occurrences="2">
<code>XDEBUG_CC_UNUSED</code>
<code>XDEBUG_CC_DEAD_CODE</code>
<UndefinedConstant occurrences="5">
<code>\XDEBUG_FILTER_CODE_COVERAGE</code>
<code>\XDEBUG_PATH_WHITELIST</code>
<code>\XDEBUG_CC_UNUSED</code>
<code>\XDEBUG_CC_DEAD_CODE</code>
</UndefinedConstant>
</file>
<file src="src/Node/AbstractNode.php">
<InvalidReturnStatement occurrences="7"/>
<InvalidReturnType occurrences="7">
<code>int|string</code>
<code>int|string</code>
<code>int|string</code>
<code>int|string</code>
<code>int|string</code>
<code>int|string</code>
<code>int|string</code>
</InvalidReturnType>
<PossiblyNullPropertyAssignmentValue occurrences="1">
<code>$parent</code>
</PossiblyNullPropertyAssignmentValue>
Expand Down
Loading