Improve consistency in handling of namespaces #750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @sebastianbergmann
In #455, the internal classname used as an array key by the report was adjusted from using the simple classname to the FQCN. However although traits use the same basic data structure, the same adjustment was not done for them. This PR fixes that so the correct data can be stored and looked up.
Namespaced functions seem to be OK as the namespace is already included in the result of
->getName()
.The fix from #455 also seems to have a side-effect on the text report, since this had seperate code to include the namespace in the output. With the classname now being the FQCN, the text report has been doubling up output for the last couple of years. This PR therefore also adjusts the text report to eliminate that.
Before
After