Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use saveXml() instead of save() #721

Conversation

duncan3dc
Copy link
Contributor

As reported in issue #692 there seems to be an issue writing the XML code coverage to disk when using the \SoapClient class. This PR gets around that issue by using saveXml() to generate the XML and the file_put_contents() to write it

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #721 into master will decrease coverage by 2.53%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #721      +/-   ##
============================================
- Coverage      85.1%   82.56%   -2.54%     
- Complexity      812      843      +31     
============================================
  Files            32       36       +4     
  Lines          2443     2529      +86     
============================================
+ Hits           2079     2088       +9     
- Misses          364      441      +77
Impacted Files Coverage Δ Complexity Δ
src/Report/Xml/Facade.php 91.53% <100%> (ø) 33 <0> (ø) ⬇️
src/Driver/Xdebug.php 8.82% <0%> (ø) 15% <0%> (?)
src/Driver/PHPDBG.php 10.34% <0%> (ø) 13% <0%> (?)
src/Driver/Driver.php 0% <0%> (ø) 0% <0%> (?)
src/Driver/PCOV.php 30% <0%> (ø) 3% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96bb791...f78db8a. Read the comment docs.

@sebastianbergmann
Copy link
Owner

@theseer Do you have an idea what could be going on here? Thanks!

@sebastianbergmann sebastianbergmann merged commit 7951767 into sebastianbergmann:master Jan 29, 2020
@duncan3dc duncan3dc deleted the dom-document-save-workaround branch February 4, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants