Prioritize pcov above xdebug #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #709 +/- ##
=========================================
Coverage 85.13% 85.13%
Complexity 812 812
=========================================
Files 32 32
Lines 2476 2476
=========================================
Hits 2108 2108
Misses 368 368
Continue to review full report at Codecov.
|
|
Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it as I do not think that there is an issue to solve here: simply do not load Xdebug and PCOV at the same time. |
|
Changed my mind, thank you for your contribution. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pcov is a much faster code coverage driver and in situtation where both Xdebug and pcov are installed it should be used above xdebug in my opinion.
I've tested with a codebase with some 40k lines of code and 4000 tests.
It is a change in behavior though as pcov and xdebug might collect different coverage information