Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set popover boundary to viewport #659

Closed

Conversation

derdiggn
Copy link

@derdiggn derdiggn commented Dec 7, 2018

Fixes #655

@derdiggn
Copy link
Author

derdiggn commented Dec 7, 2018

Hello @sebastianbergmann,
this is a small fix four the positioning problem.

regards 

@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #659 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #659   +/-   ##
=========================================
  Coverage     85.16%   85.16%           
  Complexity      805      805           
=========================================
  Files            32       32           
  Lines          2534     2534           
=========================================
  Hits           2158     2158           
  Misses          376      376
Impacted Files Coverage Δ Complexity Δ
src/Report/Html/Renderer/File.php 91.15% <100%> (ø) 110 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdba7cf...3ebe48b. Read the comment docs.

@sebastianbergmann
Copy link
Owner

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided to merge #658 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants