Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: wrong use of recursive iterator causing duplicate entries in XML coverage report #515

Closed
wants to merge 2 commits into from

Conversation

theseer
Copy link
Contributor

@theseer theseer commented Mar 31, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 31, 2017

Codecov Report

Merging #515 into master will increase coverage by 0.06%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #515      +/-   ##
============================================
+ Coverage     86.36%   86.43%   +0.06%     
+ Complexity      754      753       -1     
============================================
  Files            29       29              
  Lines          2377     2374       -3     
============================================
- Hits           2053     2052       -1     
+ Misses          324      322       -2
Impacted Files Coverage Δ Complexity Δ
src/Report/Xml/Facade.php 91.96% <75%> (+2.22%) 25 <0> (-1) ⬇️
src/Report/PHP.php 0% <0%> (ø) 2% <0%> (ø) ⬇️
src/Report/Html/Renderer/Dashboard.php 97.47% <0%> (+0.02%) 31% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b4d8b9...0a0b8e7. Read the comment docs.

@sebastianbergmann
Copy link
Owner

Merged manually, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants