Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor how code unit information is passed from PHPUnit #519

Closed
sebastianbergmann opened this issue Apr 12, 2017 · 0 comments
Closed

Refactor how code unit information is passed from PHPUnit #519

sebastianbergmann opened this issue Apr 12, 2017 · 0 comments
Labels
refactoring

Comments

@sebastianbergmann
Copy link
Owner

PHPUnit turns code unit information (@covers class::method, for instance) into filename and line numbers information which this component then uses but has to convert back into code unit information when, for instance, a CoveredCodeNotExecutedException has to be raised.

It would be better for PHPUnit to pass lists of code units (from @covers and @uses annotations) to this component instead.
@sebastianbergmann sebastianbergmann mentioned this issue Dec 7, 2017
Closed
@sebastianbergmann sebastianbergmann mentioned this issue Jul 10, 2018
Closed
2 tasks
sebastianbergmann added a commit to sebastianbergmann/code-unit that referenced this issue Mar 1, 2020
@sebastianbergmann
Let CodeUnit::fromString() return a collection of CodeUnit objects in…
470b4eb 
…stead of a CodeUnit object (even if only a single CodeUnit object is to be returned)

The purpose of this component is to help with refactoring how information from @Covers and @uses annotations is passed from phpunit/phpunit to phpunit/php-code-coverage, see sebastianbergmann/php-code-coverage#519 for details.

I want this to happen sooner rather than later and do not want to wait for PHPUnit 10 and sebastianbergmann/phpunit#3631.

This means that, at least until PHPUnit 10, this component needs to support these strings for CodeUnit::fromString():

* ClassName::<public>
* ClassName::<protected>
* ClassName::<private>
* ClassName::<!public>
* ClassName::<!protected>
* ClassName::<!private>
@sebastianbergmann sebastianbergmann mentioned this issue Aug 5, 2024
Open
sebastianbergmann added a commit that referenced this issue Oct 5, 2024
@sebastianbergmann
Initial work on value objects for #519
6c6209f
sebastianbergmann added a commit that referenced this issue Oct 9, 2024
@sebastianbergmann
Initial work on value objects for #519
a877448
This was referenced Oct 10, 2024
Open
Closed
Closed
sebastianbergmann added a commit that referenced this issue Oct 31, 2024
@sebastianbergmann
Initial work on value objects for #519
13aade2
sebastianbergmann added a commit that referenced this issue Oct 31, 2024
@sebastianbergmann
Initial work on value objects for #519
acaafb7
sebastianbergmann added a commit that referenced this issue Oct 31, 2024
@sebastianbergmann
Initial work on value objects for #519
c9ea4cb
sebastianbergmann added a commit that referenced this issue Nov 19, 2024
@sebastianbergmann
Initial work on value objects for #519
acb8012
sebastianbergmann added a commit that referenced this issue Dec 7, 2024
@sebastianbergmann
Initial work on value objects for #519
66d1136
@sebastianbergmann sebastianbergmann mentioned this issue Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sebastianbergmann