update LTV1 by difference in CRPIX1 between direct and spectral image

[n-bachmann]

solves problem of misaligned trace

[sebastian-zieba]

Hi @n-bachmann ,
Thanks a lot! I will try this on a few datasets to make sure that it works regardless of subarray size and grism.

[sebastian-zieba]

Relevant for issue #21 and issue #24

[sebastian-zieba]

Looks like this PR fixes the bug for:

• TOI-1201 (GO17192) Array256 G141
• TOI-561 (GO17192) Array256 G141

I will test it for some other datasets (with a range of subarrays and grims) to be sure that this PR won't create new problems. I'll try:

• KELT11 (GO15255) Array512 G141 (worked pre-PR)
• HD189 (GO16180) Array512 G141 (worked pre-PR)
• HD209 (GO 12181) Array256 G141 (experienced the same bug like the datasets above)
• GJ1214 (GO13021) Array256 G141 (worked pre-PR)
• KELT11 (GO15926) Array512 G102 (worked pre-PR)

These tests shouldn't take too long.

[sebastian-zieba]

Looks good. I tested the datasets:

KELT11 (GO15255) Array512 G141

HD189 (GO16180) Array512 G141

HD209 (GO 12181) Array256 G141

GJ1214 (GO13021) Array256 G141

KELT11 (GO15926) Array512 G102

[sebastian-zieba]

Looks all good! Thanks!

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (2a6fe89) 0.00% compared to head (ac3e189) 0.00%.

Files	Patch %	Lines
src/pacman/s10_direct_images.py	0.00%	4 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff           @@
##           master     #23   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          57      57           
  Lines        4838    4840    +2     
======================================
- Misses       4838    4840    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.