Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site link type doesn't work if base URL is an environment variable #128

Closed
ItagMichael opened this issue Oct 29, 2020 · 3 comments
Closed

Site link type doesn't work if base URL is an environment variable #128

ItagMichael opened this issue Oct 29, 2020 · 3 comments
Labels
bug

Comments

@ItagMichael
Copy link

Hi,

I have a site with the Base URL set to be an environment variable $DEFAULT_SITE_URL.

When using a link type of Site, and selecting this site, the link output is literally <a href="$DEFAULT_SITE_URL">...</a>. Am I just misunderstanding how this should work here?

Craft 3.4.30, craft-linkfield 1.0.23
sebastian-lenz added a commit that referenced this issue Nov 7, 2020
@sebastian-lenz
Resolve environment variables in site link, resolves #128
ef82352
@sebastian-lenz
Copy link
Owner

Hi @ItagMichael, thanks for reporting this. I've changed the site link type to correctly return site urls containing environment variables.

sebastian-lenz added a commit that referenced this issue Nov 7, 2020
@sebastian-lenz
Resolve environment variables in site link, resolves #128
3b2caff
@nixondesigndev
Copy link

Could we get a new release with this fix?

@sebastian-lenz
Copy link
Owner

I'll release a new version as soon as I've checked upon the other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sebastian-lenz @ItagMichael @nixondesigndev