Skip to content

Commit

Permalink
Revert "[fix](routine-load) fix auto resume invalid when FE leader ch…
Browse files Browse the repository at this point in the history
…ange (apache#37071)" (apache#37804)

revert (apache#37071)

It will only call the `write` method to write the edit log when creating
the routine load job, but will not use this method when change job state
to pause, but use the logic:
```
Env.getCurrentEnv().getEditLog().logOpRoutineLoadJob(new RoutineLoadOperation(id, jobState));
```
Therefore, using the logic:
```
@SerializedName("pr")
protected ErrorReason pauseReason;
```
only persist pauseReason when create job, rather than pause job, which
means `pauseReason` will not be persist when it is assigned due to
pause, causing auto resume still invalid if FE leader change when job
pause.
  • Loading branch information
sollhui authored and seawinde committed Jul 17, 2024
1 parent 5287703 commit fde6a4b
Showing 1 changed file with 0 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -242,16 +242,11 @@ public boolean isFinalState() {
@SerializedName("pg")
protected RoutineLoadProgress progress;

@SerializedName("lrt")
protected long latestResumeTimestamp; // the latest resume time
@SerializedName("art")
protected long autoResumeCount;
// some other msg which need to show to user;
@SerializedName("om")
protected String otherMsg = "";
@SerializedName("pr")
protected ErrorReason pauseReason;
@SerializedName("cr")
protected ErrorReason cancelReason;

@SerializedName("cts")
Expand Down

0 comments on commit fde6a4b

Please sign in to comment.