Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce more specific model types in incidenceMapR #131

Open
famulare opened this issue Jan 7, 2020 · 0 comments
Open

introduce more specific model types in incidenceMapR #131

famulare opened this issue Jan 7, 2020 · 0 comments
Labels
refactor Restructure code to improve speed/maintainability/readability/etc science Issues related to science behind the software

Comments

@famulare
Copy link
Member

famulare commented Jan 7, 2020

The original abstraction that we always want smoothModel or latentFieldModel is broken. We really want intensityModel (current latentFieldModel), DeDxModel and catchmentModel (both variants of smoothModel but with different rules for handling site_type (DeDx==random effects, catchment == replicate/fixed effect).

famulare added a commit that referenced this issue Jan 7, 2020
… THERE'S A LOT OF TECHNICAL DEBT PILING UP!

Changes on the path to now
- `sfs_year` handling in dbViewR
- revert smoothModel handling of site_type to do catchment correctly. This breaks DeDx models. See #131.
@devclinton devclinton added refactor Restructure code to improve speed/maintainability/readability/etc science Issues related to science behind the software labels Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Restructure code to improve speed/maintainability/readability/etc science Issues related to science behind the software
Projects
None yet
Development

No branches or pull requests

2 participants