Update views to use neighborhood district & PUMA #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kairstenfay
reviewed
Feb 21, 2020
kairstenfay
approved these changes
Feb 21, 2020
Exports residenct PUMA and neighborhood district instead of census tract
joverlee521
force-pushed
the
update-views-with-puma-neighborhood
branch
from
d158881 to
2c61a06
Compare
|
Reworked sqitch changes to fix merge conflicts with master |
Exports neighborhood or PUMA for location and removes census tract.
Add `shipping.incidence_model_observation_v4`, `warehouse.puma`, and `warehouse.neighborhood_district`. Remove grants on `warehouse.tract`.
joverlee521
force-pushed
the
update-views-with-puma-neighborhood
branch
from
2c61a06 to
f5d9744
Compare
kairstenfay
force-pushed
the
update-views-with-puma-neighborhood
branch
5 times, most recently
from
073efea to
22cf861
Compare
joverlee521
force-pushed
the
update-views-with-puma-neighborhood
branch
from
22cf861 to
f5d9744
Compare
kairstenfay
reviewed
Feb 25, 2020
| to_char((encountered at time zone 'US/Pacific')::date, 'IYYY-"W"IW') as encountered_week, | ||
|
|
||
| site.details->>'type' as site_type, | ||
| site.details->>'category' as site_category, |
There was a problem hiding this comment.
why did you add site_category?
There was a problem hiding this comment.
This removed an extra join in metadata_for_augur_build with warehouse.site that was used to get the site_category. I thought we might as well include it in the modeling view
|
@joverlee521 @tsibley can we merge this? |
I think I'd prefer to hold off on merging it for now. There are some changes I'd like to see and getting this merged isn't urgent, AFAICT. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like switching from census tract to neighborhood and/or PUMA is a big enough change to warrant a bump in version number.
Adds
shipping.incidence_model_observation_v4andshipping.metadata_for_augur_build_v4and creates v4 API endpoint for augur build metadata.Also adds warehouse views
warehouse.pumaandwarehouse.neighborhood_district.