-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept Plain functions in every combinator #155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Merged
diogob
force-pushed
the
tagged-composable
branch
from
June 25, 2024 12:46
ccebffa
to
17e59fe
Compare
diogob
force-pushed
the
tagged-composable
branch
from
June 25, 2024 12:50
17e59fe
to
0990ceb
Compare
gustavoguichard
force-pushed
the
tagged-composable
branch
from
June 26, 2024 21:46
1ad27da
to
5bb1ce9
Compare
gustavoguichard
force-pushed
the
tagged-composable
branch
2 times, most recently
from
June 26, 2024 21:56
1f2a7ce
to
c83bbb0
Compare
gustavoguichard
force-pushed
the
tagged-composable
branch
from
June 26, 2024 22:07
c83bbb0
to
a40510d
Compare
gustavoguichard
changed the title
Tag composables at type level and runtime
Accept Plain functions in every combinator
Jun 26, 2024
diogob
previously approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introducing the tagging of composables at both type and runtime levels:
fn.kind = 'composable'
This allows us to achieve:
Composable<Composable<() => void>> === Composable<() => void>
.And by doing so we are now able to accept plain functions in any combinator, like so:
There are still 2 todos to my goal:
branch
resolver function be able to return plain functions instead of only composables or nullapplySchema
work with plain functions and then we can deprecatewithSchema
because they will be virtually the sameI think this PR as is can be merged and the remaining tasks can come later as new features.