Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function for sequential compositions with same arguments #142

Closed
wants to merge 1 commit into from

Conversation

gustavoguichard
Copy link
Collaborator

TODO:

@gustavoguichard
Copy link
Collaborator Author

I'm not sure how to name this function. tap seems like a nice name but it is not quite what is happening here.
It is probably one of the applications of this combinator, like running side effects in sequence.

Ramda has a definition for tap: https://ramdajs.com/0.21.0/docs/#tap
Rxjx also has a definition for it: https://rxjs.dev/api/index/function/tap

@diogob
Copy link
Contributor

diogob commented May 24, 2024

Ramda has a definition for tap: https://ramdajs.com/0.21.0/docs/#tap
Rxjx also has a definition for it: https://rxjs.dev/api/index/function/tap

I think what bothers me with the tap name is that on both the examples it refers to some subject (object in Ramda and Observable in RxJS) we return once the computations as done.

In our case, since we have only a function that receives all the computations and must return another computation, the name tap feels counter-intuitive.

@gustavoguichard
Copy link
Collaborator Author

Just to register it here too: What about allInSequence?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants