Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not error when passing parameters to a DF created with makeDomainFunction() #125

Closed
wants to merge 2 commits into from

Conversation

diogob
Copy link
Contributor

@diogob diogob commented Nov 29, 2023

Based on this discussion
Note that this is a breaking change, even though unlikely, someone might be relying on the error of an undefined parser.

I think it is a nicer default behaviour though. And the previous behaviour is easy to reproduce by passing a z.undefined(). We can add this note on the release.

Copy link
Collaborator

@gustavoguichard gustavoguichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diogob diogob marked this pull request as ready for review November 29, 2023 16:35
@diogob diogob force-pushed the ignore-input-on-undefined-input-parser branch from f89ede5 to 9cac8b0 Compare November 29, 2023 17:14
@diogob
Copy link
Contributor Author

diogob commented Nov 29, 2023

I'll hold this merge since we might want to release a minor version with the primitives before 3.0

@diogob diogob marked this pull request as draft November 29, 2023 17:26
@diogob diogob added the enhancement New feature or request label Jan 5, 2024
@diogob diogob force-pushed the ignore-input-on-undefined-input-parser branch from 9cac8b0 to ddbaa0b Compare January 6, 2024 02:06
@diogob diogob marked this pull request as ready for review January 6, 2024 02:06
@diogob diogob marked this pull request as draft January 6, 2024 02:07
…Also remove the validation from our default undefined parser and simply ignore the input, since that seems more useful on compositions than erroring in case something is passed.
@diogob diogob force-pushed the ignore-input-on-undefined-input-parser branch from ddbaa0b to 6b8f747 Compare February 14, 2024 14:59
@diogob
Copy link
Contributor Author

diogob commented May 17, 2024

This will be part of the next big breaking release. They are composable 😎

@diogob diogob closed this May 17, 2024
@diogob diogob deleted the ignore-input-on-undefined-input-parser branch May 20, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 breaking enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants