[avmfritz] Minor improvements in code an documentation (openhab#9464)

Signed-off-by: Christoph Weitkamp <[email protected]>
seaside1 · Dec 28, 2020 · c2b91af · c2b91af
1 parent 3784130
commit c2b91af
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 17 deletions.
diff --git a/bundles/org.openhab.binding.avmfritz/README.md b/bundles/org.openhab.binding.avmfritz/README.md
@@ -160,9 +160,9 @@ The AIN (actor identification number) can be found in the FRITZ!Box interface ->
 
 | Channel Type ID | Item Type                | Description                                                                                                                                        | Available on thing                                                                                                  |
 |-----------------|--------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------|
-| incoming_call   | Call                     | Details about incoming call.                                                                                                                       | FRITZ!Box                                                                                                           |
-| outgoing_call   | Call                     | Details about outgoing call.                                                                                                                       | FRITZ!Box                                                                                                           |
-| active_call     | Call                     | Details about active call.                                                                                                                         | FRITZ!Box                                                                                                           |
+| incoming_call   | Call                     | Details about incoming call. %2$s contains the external, calling number, %1$s is the internal, receiving number.                                   | FRITZ!Box                                                                                                           |
+| outgoing_call   | Call                     | Details about outgoing call. %1$s contains the external, called number, %2$s is the internal, calling number.                                      | FRITZ!Box                                                                                                           |
+| active_call     | Call                     | Details about active call. %1$s contains the external, calling number, %2$s is empty.                                                              | FRITZ!Box                                                                                                           |
 | call_state      | String                   | Details about current call state, either IDLE, RINGING, DIALING or ACTIVE.                                                                         | FRITZ!Box                                                                                                           |
 | apply_template  | String                   | Apply template for device(s) (channel's state options contains available templates, for an alternative way see the description below) - FRITZ!OS 7 | FRITZ!Box, FRITZ!Powerline 546E                                                                                     |
 | mode            | String                   | States the mode of the device (MANUAL/AUTOMATIC/VACATION)                                                                                          | FRITZ!DECT 210, FRITZ!DECT 200, FRITZ!Powerline 546E, FRITZ!DECT 301, FRITZ!DECT 300, Comet DECT                    |

diff --git a/.../src/main/java/org/openhab/binding/avmfritz/internal/AVMFritzTlsTrustManagerProvider.java b/.../src/main/java/org/openhab/binding/avmfritz/internal/AVMFritzTlsTrustManagerProvider.java
@@ -22,7 +22,7 @@
 /**
  * Provides a TrustManager to allow secure connections to any FRITZ!Box
  *
- * @author Chritoph Weitkamp - Initial Contribution
+ * @author Christoph Weitkamp - Initial Contribution
  */
 @Component
 @NonNullByDefault

diff --git a/...avmfritz/src/main/java/org/openhab/binding/avmfritz/internal/callmonitor/CallMonitor.java b/...avmfritz/src/main/java/org/openhab/binding/avmfritz/internal/callmonitor/CallMonitor.java
@@ -45,10 +45,10 @@ public class CallMonitor {
     private final int MONITOR_PORT = 1012;
 
     private @Nullable CallMonitorThread monitorThread;
-    private ScheduledFuture<?> reconnectJob;
+    private final ScheduledFuture<?> reconnectJob;
 
-    private String ip;
-    private BoxHandler handler;
+    private final String ip;
+    private final BoxHandler handler;
 
     public CallMonitor(String ip, BoxHandler handler, ScheduledExecutorService scheduler) {
         this.ip = ip;

diff --git a/...ding.avmfritz/src/main/java/org/openhab/binding/avmfritz/internal/handler/BoxHandler.java b/...ding.avmfritz/src/main/java/org/openhab/binding/avmfritz/internal/handler/BoxHandler.java
@@ -12,13 +12,13 @@
  */
 package org.openhab.binding.avmfritz.internal.handler;
 
-import java.util.HashSet;
+import static org.openhab.binding.avmfritz.internal.AVMFritzBindingConstants.*;
+
 import java.util.Set;
 
 import org.eclipse.jdt.annotation.NonNullByDefault;
 import org.eclipse.jdt.annotation.Nullable;
 import org.eclipse.jetty.client.HttpClient;
-import org.openhab.binding.avmfritz.internal.AVMFritzBindingConstants;
 import org.openhab.binding.avmfritz.internal.AVMFritzDynamicCommandDescriptionProvider;
 import org.openhab.binding.avmfritz.internal.callmonitor.CallMonitor;
 import org.openhab.binding.avmfritz.internal.config.AVMFritzBoxConfiguration;
@@ -38,14 +38,8 @@
 @NonNullByDefault
 public class BoxHandler extends AVMFritzBaseBridgeHandler {
 
-    protected static final Set<String> CALL_CHANNELS = new HashSet<>();
-    static {
-        // TODO: We are still on Java 8 and cannot use Set.of
-        CALL_CHANNELS.add(AVMFritzBindingConstants.CHANNEL_CALL_ACTIVE);
-        CALL_CHANNELS.add(AVMFritzBindingConstants.CHANNEL_CALL_INCOMING);
-        CALL_CHANNELS.add(AVMFritzBindingConstants.CHANNEL_CALL_OUTGOING);
-        CALL_CHANNELS.add(AVMFritzBindingConstants.CHANNEL_CALL_STATE);
-    }
+    private static final Set<String> CALL_CHANNELS = Set.of(CHANNEL_CALL_ACTIVE, CHANNEL_CALL_INCOMING,
+            CHANNEL_CALL_OUTGOING, CHANNEL_CALL_STATE);
 
     private @Nullable CallMonitor callMonitor;