Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress Waterfall.flow stack trace #26

Open
tandrewnichols opened this issue Feb 28, 2014 · 4 comments
Open

Suppress Waterfall.flow stack trace #26

tandrewnichols opened this issue Feb 28, 2014 · 4 comments

Comments

@tandrewnichols
Copy link

Because it's async, every new test adds a level to the stack, so if test 57 fails, you see A LOT of "Waterfall.flow" in the stack trace. With multiple errors, it becomes really hard to find the actual error.

@searls
Copy link
Owner

searls commented Feb 28, 2014

👍 I think  we need to unrecursify this.

On Fri, Feb 28, 2014 at 5:04 PM, Andrew Nichols [email protected]
wrote:

Because it's async, every new test adds a level to the stack, so if test 57 fails, you see A LOT of "Waterfall.flow" in the stack trace. With multiple errors, it becomes really hard to find the actual error.

Reply to this email directly or view it on GitHub:
#26

@tandrewnichols
Copy link
Author

Perhaps. There's also this, which could make handling long stack traces easier: https://github.com/felixge/node-stack-trace

@searls
Copy link
Owner

searls commented Mar 9, 2014

99% of given use isn't on node though

On Sun, Mar 9, 2014 at 2:41 PM, Andrew Nichols [email protected]
wrote:

Perhaps. There's also this, which could make handling long stack traces easier: https://github.com/felixge/node-stack-trace

Reply to this email directly or view it on GitHub:
#26 (comment)

@tandrewnichols
Copy link
Author

Ah, I see. Unrecursify it is then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants