This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Discovered NPE when discovery is enabled and nodes do not have http_address element #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abled set to false) will not have the http_address element as part of their result. To avoid a NPE need to check that the element exists before trying to get it as a string.
kramer
pushed a commit
that referenced
this pull request
Jul 29, 2014
bugfix: NPE when discovery is enabled and nodes do not have http_address element
|
Thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cluster nodes (i.e. logstash nodes or I imagine any with http.enabled set to false) will not have the http_address element as part of their result. To avoid a NPE, need to check that the element exists before trying to get it as a string.