Implement Ord and PartialOrd for UniCase<AsRef<str>> #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Implementing |
|
I'm not familiar with |
| fn cmp(&self, other: &Self) -> Ordering { | ||
| let self_chars = self.as_ref().chars().map(|c| c.to_ascii_lowercase()); | ||
| let other_chars = other.as_ref().chars().map(|c| c.to_ascii_lowercase()); | ||
| self_chars.cmp(other_chars) |
There was a problem hiding this comment.
It seems this is using an unstable feature, so the tests don't pass on stable.
There was a problem hiding this comment.
Or I could wait until Thursday :)
|
Compiles on stable now :) |
|
Woo! |
seanmonstar
added a commit
that referenced
this pull request
Dec 11, 2015
Implement Ord and PartialOrd for UniCase<AsRef<str>>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.