Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.8.8 tls backport #344

Closed
wants to merge 2 commits into from
Closed

Conversation

pfernie
Copy link
Contributor

@pfernie pfernie commented Sep 15, 2018

A backport of commits 11f8588 and c417d6d in order to support more recent native-tls to address #336. These commits include upgrading hyper to 0.12.

@otavio
Copy link

otavio commented Sep 15, 2018

It seems to break the current API. It changes some public API and it is a problem for a 0.8.x release.

@pfernie
Copy link
Contributor Author

pfernie commented Sep 16, 2018

True; changes related to the hyper upgrade end up having an impact on the public API here. Closing this PR as unsuitable for the 0.8 branch; I see there is a feature on master hyper011 to "ease transition", perhaps incorporating those changes will allow for this backport while maintaining compatibility.

@est31
Copy link
Contributor

est31 commented Sep 18, 2018

It seems that both hyper-tls and tokio-tls would need upgrades for a native-tls upgrade to happen. They require newer hyper though and hyper stuff is being reexported, so we can't upgrade it. Thus we'd have to find a way to backport the native-tls upgrade onto older hyper-tls and tokio-tls versions. This would be a giant endeavour and not sure whether it would work out at all.

I think it'd be best to ask @seanmonstar for a soon 0.9 reqwest release so that users don't have to use it from git (some can't because they are publishing to crates.io).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants