Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove tower as dependency for wasm32-unknown-unknown #2510

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

jlizen
Copy link
Contributor

@jlizen jlizen commented Dec 29, 2024

Closes #2509

This addresses the change likely that caused the wasm regression.

(EDIT: I've now reproduced the failure and can confirm this fixes it)


Changes to dependencies on wasm32-unknown-unknown:

Old (has tower):

> cargo tree --target wasm32-unknown-unknown

reqwest v0.12.11 (/workplace/jlizen/reqwest)
<snip>
├── tower v0.5.2
│   ├── futures-core v0.3.31
│   ├── futures-util v0.3.31 (*)
│   ├── pin-project-lite v0.2.15
│   ├── sync_wrapper v1.0.2 (*)
│   ├── tokio v1.42.0
│   │   └── pin-project-lite v0.2.15
│   ├── tokio-util v0.7.13
│   │   ├── bytes v1.9.0
│   │   ├── futures-core v0.3.31
│   │   ├── futures-sink v0.3.31
│   │   ├── pin-project-lite v0.2.15
│   │   └── tokio v1.42.0 (*)
│   ├── tower-layer v0.3.3
│   ├── tower-service v0.3.3
│   └── tracing v0.1.41
│       ├── pin-project-lite v0.2.15
│       └── tracing-core v0.1.33
│           └── once_cell v1.20.2
├── tower-service v0.3.3
<snip>
[dev-dependencies]
<snip>

New (tower is only for tests):

cargo tree --target wasm32-unknown-unknown
reqwest v0.12.11 (/workplace/jlizen/reqwest)
<snip>
├── tower-service v0.3.3
<snip>
[dev-dependencies]
<snip>
├── tower v0.5.2
│   ├── futures-core v0.3.31
│   ├── pin-project-lite v0.2.15
│   ├── tokio v1.42.0
│   │   └── pin-project-lite v0.2.15
│   ├── tokio-util v0.7.13
│   │   ├── bytes v1.9.0
│   │   ├── futures-core v0.3.31
│   │   ├── futures-sink v0.3.31
│   │   ├── pin-project-lite v0.2.15
│   │   └── tokio v1.42.0 (*)
│   ├── tower-layer v0.3.3
│   ├── tower-service v0.3.3
│   └── tracing v0.1.41
│       ├── pin-project-lite v0.2.15
│       └── tracing-core v0.1.33
│           └── once_cell v1.20.2
<snip>

@jlizen
Copy link
Contributor Author

jlizen commented Dec 29, 2024

Got a reproduction from @jonatino and confirmed that the fix is good. Will follow up with a change to improve CI separately.

Copy link
Owner

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick patch!

@seanmonstar seanmonstar merged commit 1ef8703 into seanmonstar:master Dec 30, 2024
36 checks passed
AaronDewes pushed a commit to AaronDewes/reqwest-no-rustls that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.12.11 breaks my wasm-unknown-unknown build
2 participants