feat: Expose streaming as public API wrap
#2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
commented
Apr 22, 2024
src/async_impl/body.rs
Outdated
| /// # Optional | ||
| /// | ||
| /// This requires the `stream` feature to be enabled. | ||
| pub fn streaming<B>(inner: B) -> Body |
There was a problem hiding this comment.
I'm not sure if it's ok to keep the naming. I'm open to other candidates. cc @seanmonstar
There was a problem hiding this comment.
Hm, maybe Body::wrap(other)? Since a particular implementation might not actually be streaming?
There was a problem hiding this comment.
DONE. @seanmonstar, please take a look.
Signed-off-by: Xuanwo <[email protected]>
Xuanwo
force-pushed
the
expose-streaming
branch
from
0ac9e48
to
6d1af6a
Compare
|
Hi, @seanmonstar, do you think it's a good time for us to expose this API? |
Xuanwo
changed the title
streaming as public API wrap
Signed-off-by: Xuanwo <[email protected]>
seanmonstar
approved these changes
Sep 4, 2024
|
Thanks! |
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Oct 1, 2024
Bumps reqwest from 0.12.7 to 0.12.8. Release notes Sourced from reqwest's releases. v0.12.8 What's Changed Add support for SOCKS4 proxies. Add multipart::Form::file() method for adding files easily. Add Body::wrap() to wrap any http_body::Body type. Fix the pool configuration to use a timer to remove expired connections. New Contributors @workingjubilee made their first contribution in seanmonstar/reqwest#2402 @NaokiM03 made their first contribution in seanmonstar/reqwest#2106 @Xuanwo made their first contribution in seanmonstar/reqwest#2255 @Jaltaire made their first contribution in seanmonstar/reqwest#2400 @Hyask made their first contribution in seanmonstar/reqwest#2418 @Jake-Shadle made their first contribution in seanmonstar/reqwest#2427 @RobMor made their first contribution in seanmonstar/reqwest#2434 Full Changelog: seanmonstar/[email protected] Changelog Sourced from reqwest's changelog. v0.12.8 Add support for SOCKS4 proxies. Add multipart::Form::file() method for adding files easily. Add Body::wrap() to wrap any http_body::Body type. Fix the pool configuration to use a timer to remove expired connections. Commits 95fec09 v0.12.8 baf9712 fix: pass pool_timer to hyper_util to enable the idle cleanup task (#2434) d85f44b Bump rustls-native-certs (#2427) c8665be tests: use a documented test network for testing 964b1c6 tests: bypass the proxy when testing timeouts 09884ed feat: Add support for SOCKS4 (#610) (#2400) a13a6bc ci: pin tokio-util for msrv job (#2412) 4cc8ec8 feat: Expose streaming as public API wrap (#2255) cc3dd51 Add file function to async::multipart (#2106) 193ed1f chore: Depend on wasm-bindgen 0.2.89 or higher See full diff in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Nutomic
pushed a commit
to Nutomic/reqwest
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2243