Fix SIMD header value check on char >= 0x80 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SIMD intrinsics *_cmpgt_epi8 are for signed chars. This change correctly performs the unsigned comparison.
|
Could you describe the problem a bit more? Why does it matter that the intrinsics are for signed chars? Is there a bug in current httparse? |
|
The intention of the code is to check if the char is greater than 0x1f. However for a char >= 0x80, *_cmpgt_epi8 treats it as negative number. So all the chars that >= 0x80 are treated as if they are <= 0x1f, which will make them to be rejected as illegal header values. |
nox
approved these changes
Jan 14, 2022
seanmonstar
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SIMD intrinsics *_cmpgt_epi8 are for signed chars.
This change correctly performs the unsigned comparison.