[WIP] Priority Queue Implementation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanlaii
force-pushed
the
priority-queue
branch
2 times, most recently
from
ab5c8cb to
e6a690b
Compare
seanlaii
commented
Aug 21, 2024
pkg/scheduler/event_handler.go
Outdated
| s.queue.Add(key) | ||
| s.queue.Add(priorityqueue.DataWithPriority{ | ||
| Key: key, | ||
| Priority: 1, |
seanlaii
force-pushed
the
priority-queue
branch
7 times, most recently
from
3dd7507 to
f11ef8b
Compare
wengyao04
reviewed
Aug 28, 2024
| workqueue.DelayingQueueConfig{ | ||
| Name: queueName, | ||
| Clock: clock, | ||
| Queue: priorityqueue.NewWithConfig( |
There was a problem hiding this comment.
Could we add a Featuregateway to allow user default to the fifo queue ?
seanlaii
force-pushed
the
priority-queue
branch
from
f11ef8b to
8b5d2b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: