Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC #405
Approach
Change the internal presentation of sql from string to nested vector of sql fragments.
Convert back to SQL string only on public consumer API
sql/format
,sql/format-expr
.(str ...)
and(str/join ...)
tovector
/interpose
."?"
to marker:parameter-marker
Good
helper
orformat
Bad
Checklist
Thoughts
[sqls params]
, all external fn to output[sql param1 param2 ...]
may help to make code even more concise.format-expr
separate intoformat-expr
and-format-expr
.