Adding variable to define Custom browser to use #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added custom variable `grip-url-browser` to specify another browser to be used instead of default one. Added function grip--browser which will load preview either by using grip-url-browser or default browser
seagle0128
requested changes
May 12, 2021
All the changes have been updated as you said. I also made sure that these changes are working as expected. Let was giving me symbol's defination is void function something Like that so by searching online I found setq-local.
seagle0128
requested changes
May 13, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option for user to specify using different browser(other than default one) for org/markdown previews. Its working for me right now, but will need further testing for any edge cases(if they exist).
Also updated README to include how to set the variable.