Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial draft of rotposatt.py routine. #71

Closed
wants to merge 6 commits into from

Conversation

johnbdesanto
Copy link
Collaborator

Routine is currently incomplete, needs syntax review. Also needs subroutines for xyz2enu and enu2xyz to be implemented, which are in the Fortran code. These subroutines require a longitude and latitude, which can be generated by other Fortran scripts in the old software, but there may be a tool already existing in python, pyproj, that can perform these actions. Needs investigation.

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 38.35% and project coverage change: +29.66 🎉

Comparison is base (d77341c) 24.39% compared to head (fdb0229) 54.05%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #71       +/-   ##
===========================================
+ Coverage   24.39%   54.05%   +29.66%     
===========================================
  Files           6        7        +1     
  Lines         164      111       -53     
===========================================
+ Hits           40       60       +20     
+ Misses        124       51       -73     
Impacted Files Coverage Δ
src/seagap/__main__.py 0.00% <0.00%> (ø)
src/seagap/rotposatt.py 0.00% <0.00%> (ø)
src/seagap/cli.py 34.14% <34.14%> (ø)
src/seagap/__init__.py 100.00% <100.00%> (ø)
src/seagap/constants.py 100.00% <100.00%> (ø)
src/seagap/harmonic_mean.py 88.88% <100.00%> (+0.65%) ⬆️
src/seagap/utilities/io.py 85.18% <100.00%> (+1.18%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lsetiawan
Copy link
Member

Also needs subroutines for xyz2enu and enu2xyz to be implemented, which are in the Fortran code.

Currently there's a draft PR #69 that will satisfy these. Though that PR needs some tests before it's ready.

src/seagap/rotposatt.py Outdated Show resolved Hide resolved
src/seagap/rotposatt.py Outdated Show resolved Hide resolved
src/seagap/rotposatt.py Outdated Show resolved Hide resolved
@lsetiawan
Copy link
Member

@johnbdesanto I've committed a couple of the suggested changes. You should be able to pull these changes locally. Also #69 is almost done. Need a final review then it's ready to be merged.

@lsetiawan
Copy link
Member

This PR is now stale. After discussion with @johnbdesanto, we decided that @SquirrelKnight will be contributing code for this routine.

@lsetiawan lsetiawan closed this May 26, 2023
@johnbdesanto johnbdesanto deleted the rotposatt branch June 14, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants