Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Residual range limit #316

Merged

Conversation

johnbdesanto
Copy link
Collaborator

This update adds an alternative method for flagging residuals, where the user declares a range threshold for the allowable distance between the maximum and minimum residuals from a ping. It also adds appropriate documentation.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.39%. Comparing base (904102c) to head (c237832).
Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
src/gnatss/ops/io.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
+ Coverage   76.38%   76.39%   +0.01%     
==========================================
  Files          29       29              
  Lines        1791     1796       +5     
==========================================
+ Hits         1368     1372       +4     
- Misses        423      424       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@SquirrelKnight SquirrelKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be working as intended. @johnbdesanto I would recommend testing and comparing your larger datasets with your previous method to see how they compare. I do see some differences, but I think this is a better hands-off approach overall.

@johnbdesanto johnbdesanto merged commit 5ee496c into seafloor-geodesy:main Oct 3, 2024
6 checks passed
@johnbdesanto johnbdesanto deleted the residual_range_limit branch October 3, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants