Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix latex formatting, and ignore file #297

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

lsetiawan
Copy link
Member

This PR fixes the issue with pre-commit reformating _{ to *{ causing the rendering to not work properly as mentioned in #290 (comment)

@lsetiawan lsetiawan requested a review from johnbdesanto July 2, 2024 17:29
Copy link
Collaborator

@johnbdesanto johnbdesanto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt

For clarity, if something like this occurs in the future the fix is to add the file to the "exclude" list in .pre-commit-config.yaml? I'd like to be able to resolve this myself if it happens again.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.20%. Comparing base (ce6d5a0) to head (5505559).
Report is 30 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   76.20%   76.20%           
=======================================
  Files          29       29           
  Lines        1786     1786           
=======================================
  Hits         1361     1361           
  Misses        425      425           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsetiawan
Copy link
Member Author

"exclude" list in .pre-commit-config.yaml

yepp if there's a file you'd like to exclude from pre-commit, you can include that file there.

@lsetiawan lsetiawan merged commit 615e6b1 into seafloor-geodesy:main Jul 2, 2024
6 checks passed
@lsetiawan lsetiawan deleted the fix_docs branch July 2, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants